⚡ Optimize InsightStore with async RwLock and O(1) storage#78
Conversation
- Replace blocking `std::sync::RwLock` with `tokio::sync::RwLock` - Make `InsightStore` trait async using `async-trait` - Optimize `InMemoryInsightStore` to avoid O(N) index rebuilding on eviction - Update `InsightLayer` to use async store methods Co-authored-by: Tuntii <121901995+Tuntii@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Run `cargo fmt` to fix CI failures in `crates/rustapi-extras/src/insight/store.rs` introduced by previous commit. Co-authored-by: Tuntii <121901995+Tuntii@users.noreply.github.com>
1 participant
std::sync::RwLockwithtokio::sync::RwLockinInMemoryInsightStore. RefactoredInsightStoretrait to be async usingasync-trait. OptimizedInMemoryInsightStorestorage to useVecDeque<Arc<InsightData>>+DashMap<String, Arc<InsightData>>to eliminate O(N) index rebuilding during eviction.PR created automatically by Jules for task 2954011930150916406 started by @Tuntii